[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

[Jagannadha Sutradharudu Teki]

From: Joel A Fernandes [mailto:agnel.joel at gmail.com]
Sent: 16 June 2013 21:15
To: Jagannadha Sutradharudu Teki
Cc: u-boot at lists.denx.de; Tom Rini
Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path



On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
From: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com>

checkpatch.pl<http://checkpatch.pl> requires perl v5.10.0 to run but it
doesn't require to place in /usr/bin/perl
Use env to ensure that the interpreter used is the
first one on environment's $PATH on system with
several versions of perl installed.

Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com>
---
 tools/checkpatch.pl<http://checkpatch.pl> | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/checkpatch.pl<http://checkpatch.pl> b/tools/checkpatch.pl<http://checkpatch.pl>
index 896e2bc..8dc5b9c 100755
--- a/tools/checkpatch.pl<http://checkpatch.pl>
+++ b/tools/checkpatch.pl<http://checkpatch.pl>
@@ -1,10 +1,11 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl

Would it not work to pass in the -w here?

Yes it will not work just to pass -w
It's taking -w as a file.

Thanks,
Jagan.

Joel

 # (c) 2001, Dave Jones. (the file handling bit)
 # (c) 2005, Joel Schopp <jschopp at austin.ibm.com> (the ugly bit)
 # (c) 2007,2008, Andy Whitcroft <apw at uk.ibm.com> (new conditions, test suite)
 # (c) 2008-2010 Andy Whitcroft <apw at canonical.com>
 # Licensed under the terms of the GNU GPL License version 2

+use warnings;
 use strict;

 my $P = $0;
--
1.8.3


_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.