[U-Boot] [U-Boot,V2] MMC: DWMMC: Fix FIFO_DEPTH calculation

Minkyu Kang mk7.kang at samsung.com
Mon Jun 17 04:07:55 CEST 2013


On 14/06/13 07:34, Andy Fleming wrote:
> On Fri, May 24, 2013 at 06:15:34PM +0530, Rajeshwari Shinde wrote:
>> Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time
>> for mmc rescan command.
>> In current code FIFO_DEPTH is getting calculated after reading the default FIFOTH
>> register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1).
>> Instead of storing the correct value, we were recalculating the FIFO_DEPT each
>> time which is not correct.
>>
>> Based on "[PATCH V9 3/9] DWMMC: Initialise dwmci and resolve EMMC read write issues"
>> http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/160247
>>
>> Signed-off-by: Hatim Ali <hatim.rv at samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>
>> Acked-by: Simon Glass <sjg at chromium.org>
>> Tested-by: Simon Glass <sjg at chromium.org>
>> Acked-by: Jaehoon Chung <jh80.chung at samsung.com>
> 
> Acked-by: Andy Fleming <afleming at freescale.com>
> 
> Looks like the patch this is based on is already accepted, but not yet
> upstream, so I'm going to delegate the patch to Minkyu Kang
> 
> 
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.


More information about the U-Boot mailing list