[U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path

Andreas Bießmann andreas.devel at googlemail.com
Mon Jun 17 08:38:26 CEST 2013


Dear Joel A Fernandes,

On 16.06.13 17:44, Joel A Fernandes wrote:
> On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote:
> 
>> From: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com<javascript:;>
>>>
>>
>> checkpatch.pl requires perl v5.10.0 to run but it
>> doesn't require to place in /usr/bin/perl
>> Use env to ensure that the interpreter used is the
>> first one on environment's $PATH on system with
>> several versions of perl installed.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com<javascript:;>
>>>
>> ---
>>  tools/checkpatch.pl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
>> index 896e2bc..8dc5b9c 100755
>> --- a/tools/checkpatch.pl
>> +++ b/tools/checkpatch.pl
>> @@ -1,10 +1,11 @@
>> -#!/usr/bin/perl -w
>> +#!/usr/bin/env perl
> 
> 
> Would it not work to pass in the -w here?

this is not portable! BSD variants of env will only take a single parameter.

Best regards

Andreas Bießmann


More information about the U-Boot mailing list