[U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

Stefano Babic sbabic at denx.de
Mon Jun 17 12:40:32 CEST 2013


On 14/06/2013 15:18, Jagan Teki wrote:

>> This does not scale.
>> What if a (trivial) patch touches 10 drivers?
> Yes, you are correct if the changes is common to across the all drivers or
> If the changes which are more in 10 spi drivers out of 20 or > 10 for
> your example - use "spi: "
> and I think it's good to use above syntax as you changesd two drivers.
> 
> I am just showing the possibilities of using the coding guidelines,
> nothing more.

There is another issue: patman recognizes each <subpart>: and checks for
an alias to find the e-mail to send patches, and stops to go on if it is
not found. In this example, you can use patman if there is an entry for
spi: (and this is you as SPI custodian) and also for mxc_spi:, and
usually there is no maintainer for each driver. I agree that using a
long chain does not scale, and I think the hidden rule to use
<subsystem:> <subject> works well in most cases, Axel did in this patchset.

Regards,
Stefano



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list