[U-Boot] [PATCH 1/4] sf: Unify spi_flash write code

[Simon Glass]

Hi Jagan,

On Wed, Jun 19, 2013 at 2:56 AM, Jagan Teki <jagannadh.teki at gmail.com>wrote:

> On Wed, Jun 19, 2013 at 10:01 AM, Simon Glass <sjg at chromium.org> wrote:
> > Hi Jagan,
> >
> > On Fri, Jun 14, 2013 at 1:18 PM, Jagannadha Sutradharudu Teki <
> > jagannadha.sutradharudu-teki at xilinx.com> wrote:
> >
> >> Move common flash write code into spi_flash_write_common().
> >>
> >> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna at xilinx.com>
> >> ---
> >>  drivers/mtd/spi/spi_flash.c          | 122
> >> ++++++++++++++++-------------------
> >>  drivers/mtd/spi/spi_flash_internal.h |   6 ++
> >>  2 files changed, 60 insertions(+), 68 deletions(-)
> >>
> >
> > This looks good except that  spi_flash_write_common() is not a great
> name -
> > only one of the operations is a 'write'. Perhaps spi_flash_oper_common()
> or
> > similar?
>
> I think it's ok to use spi_flash_write_common().
> because, I put this name as the write sequence has all theseopers
> write_enable, write and wait_ready, not by taking only write
> operation.
>
> OK well let's not worry about it too much.

Acked-by: Simon Glass <sjg at chromium.org>



> May be I will try to put spi_flash_write_oper_common()
> Any comments.??
>

Regards,
Simon