[U-Boot] [PATCH v3 0/9] Bring in new I2C framework

Piotr Wilczek p.wilczek at samsung.com
Thu Jun 20 10:34:08 CEST 2013


Dear Minkyu and Heiko,

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: Thursday, June 20, 2013 9:14 AM
> To: Piotr Wilczek
> Cc: 'Minkyu Kang'; 'Simon Glass'; 'U-Boot Mailing List'; 'Dirk Eibach';
> 'Stefan Roese'; 'Holger Brunck'; 'Mike Frysinger'; 'Stephen Warren'
> Subject: Re: [PATCH v3 0/9] Bring in new I2C framework
> 
> Hello Piotr,
> 
> Am 20.06.2013 08:41, schrieb Piotr Wilczek:
> > Dear Heiko,
> >
> >> -----Original Message-----
> >> From: Minkyu Kang [mailto:mk7.kang at samsung.com]
> >> Sent: Thursday, June 20, 2013 7:51 AM
> >> To: Heiko Schocher
> >> Cc: Simon Glass; Piotr Wilczek; U-Boot Mailing List; Dirk Eibach;
> >> Stefan Roese; Holger Brunck; Mike Frysinger; Stephen Warren
> >> Subject: Re: [PATCH v3 0/9] Bring in new I2C framework
> >>
> >> Dear Heiko,
> >>
> >> On 20/06/13 12:38, Heiko Schocher wrote:
> >>> Hello Simon,
> >>>
> >>> Am 20.06.2013 00:07, schrieb Simon Glass:
> >>>> Hi Heiko,
> >>>>
> >>>> On Sun, May 19, 2013 at 11:13 PM, Piotr Wilczek
> >> <p.wilczek at samsung.com <mailto:p.wilczek at samsung.com>> wrote:
> >>>>
> >>>>     Hi Simon,
> >>>>
> >>>>     > -----Original Message-----
> >>>>     > From: sjg at google.com <mailto:sjg at google.com>
> >> [mailto:sjg at google.com <mailto:sjg at google.com>] On Behalf Of Simon
> >> Glass
> >>>>     > Sent: Saturday, May 18, 2013 7:41 PM
> >>>>     > To: Piotr Wilczek
> >>>>     > Cc: Heiko Schocher; U-Boot Mailing List; Dirk Eibach; Stefan
> >> Roese;
> >>>>     > Holger Brunck; Mike Frysinger; Stephen Warren; Minkyu Kang
> >>>>     > Subject: Re: [PATCH v3 0/9] Bring in new I2C framework
> >>>>     >
> >>>>     > Hi Piotr,
> >>>>     >
> >>>>     > On Fri, May 17, 2013 at 6:17 AM, Piotr Wilczek
> >> <p.wilczek at samsung.com <mailto:p.wilczek at samsung.com>>
> >>>>     > wrote:
> >>>>     > > Dear Heiko,
> >>>>     > >
> >>>>     > >> -----Original Message-----
> >>>>     > >> From: Heiko Schocher [mailto:hs at denx.de
> >> <mailto:hs at denx.de>]
> >>>>     > >> Sent: Saturday, May 04, 2013 2:02 PM
> >>>>     > >> To: u-boot at lists.denx.de <mailto:u-boot at lists.denx.de>
> >>>>     > >> Cc: Heiko Schocher; Dirk Eibach; Stefan Roese; Simon
> >>>> Glass;
> >> Piotr
> >>>>     > >> Wilczek; Holger Brunck; Mike Frysinger; Stephen Warren
> >>>>     > >> Subject: [PATCH v3 0/9] Bring in new I2C framework
> >>>>     > >>
> >>>>     > >> It seems the timing is coming, to bring this finally in
> >> mainline and
> >>>>     > >> move boards over to the new i2c framework.
> >>>>     > >>
> >>>>     > >> Changes for v3 series:
> >>>>     > >>
> >>>>     > >> - Compiler collects the used i2c adapters in
> >> _u_boot_list_i2c,
> >>>>     > >>   so no need for defining the used i2c adpaters in the
> >> board config
> >>>>     > >> file.
> >>>>     > >>   -> drop CONFIG_SYS_NUM_I2C_ADAPTERS and
> >> CONFIG_SYS_I2C_ADAPTERS
> >>>>     > >> - Some adaptions for the keymile boards, so we can drop
> >>>>     > CONFIG_I2C_MUX
> >>>>     > >>   completely
> >>>>     > >> - add ppc4xx_i2c driver, ported from Dirk Eibach
> >>>>     > >>
> >>>>     > >> Serie compiles clean on arm and powerpc
> >>>>     > >>
> >>>>     > >> Ported i2c drivers:
> >>>>     > >> soft_i2c  : from me, tested on some arm and powerpc
> boards
> >>>>     > >> fsl_i2c   : from me, only compile tested
> >>>>     > >> tegra_i2c : ported from Simon Glass
> >>>>     > >> ppc4xx_i2c: adapted from Dirk Eibach
> <dirk.eibach at gdsys.cc>
> >>>>     > >>             tested on (which board?) with 4 soft_i2c
> >> drivers
> >>>>     > >>             and one ppc4x_i2c driver.
> >>>>     > >>
> >>>>     > >> Cc: Dirk Eibach <dirk.eibach at gdsys.cc>
> >>>>     > >> Cc: Stefan Roese <sr at denx.de <mailto:sr at denx.de>>
> >>>>     > >> Cc: Simon Glass <sjg at chromium.org
> >> <mailto:sjg at chromium.org>>
> >>>>     > >> Cc: Piotr Wilczek <p.wilczek at samsung.com
> >> <mailto:p.wilczek at samsung.com>>
> >>>>     > >> Cc: Holger Brunck <holger.brunck at keymile.com
> >> <mailto:holger.brunck at keymile.com>>
> >>>>     > >> Cc: Mike Frysinger <vapier at gentoo.org
> >> <mailto:vapier at gentoo.org>>
> >>>>     > >> Cc: Stephen Warren <swarren at wwwdotorg.org
> >> <mailto:swarren at wwwdotorg.org>>
> >>>>     > >>
> >>>>     > >
> >>>>     > > I ported s3c24x0_i2c driver and tested this framework on
> >> Samsung tree
> >>>>     > on Trats2 board.
> >>>>     >
> >>>>     > Please can you send a patch for this port?
> >>>>
> >>>>     I posted that patch and some others with series introducing
> >> Trsts2, where I
> >>>>     want to use this framework.
> >>>>     I'm sorry I didn't mention it in my first mail.
> >>>>     http://patchwork.ozlabs.org/patch/244645/
> >>>>     http://patchwork.ozlabs.org/patch/244644/
> >>>>     .
> >>>>     http://patchwork.ozlabs.org/patch/244638/
> >>>>     http://patchwork.ozlabs.org/patch/244637/
> >>>>     http://patchwork.ozlabs.org/patch/244640/
> >>>>     http://patchwork.ozlabs.org/patch/244636/
> >>>
> >>> Hups, missed this patches ...
> >>>
> >>>> What is the status of this series now please?
> >>>
> >
> > If you take this series, please replace the following patch:
> > http://patchwork.ozlabs.org/patch/244642/
> >
> > with the following one:
> > http://patchwork.ozlabs.org/patch/248927/
> 
> I am little confused now ... can you send a complete list which patches
> have to be picked up... thanks!
> 

This series does not apply cleanly any more on u-boot-i2c. I would have to
post an updated version.

In my opinion, It would be better that this series to be disregarded and the
new board Trats2 goes through the Samsung tree (it's been already tested).
Then later I should post new patches to adapt s3c24x0 i2c driver.

> >>> I heared nothing negatives for the new i2c multibus framework, so I
> >>> plan to merge it into mainline, if the next merge widow is open.
> >>>
> >>> So, the best for above patches would be, If I delegate them to me,
> >> and
> >>> apply them, when merging the new i2c multibus support ...
> >>>
> >>> @Minkyu: Is this OK for you?
> >>
> >> OK..
> >> please pick patches.
> 
> bye,
> Heiko
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Best regards,
Piotr Wilczek




More information about the U-Boot mailing list