[U-Boot] [PATCH] gpio: pca953x: Use ARRAY_SIZE instead of reinventing it
Marek Vasut
marex at denx.de
Sat Jun 22 15:21:49 CEST 2013
Dear Axel Lin,
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
> drivers/gpio/pca953x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
> index be13745..7371cd4 100644
> --- a/drivers/gpio/pca953x.c
> +++ b/drivers/gpio/pca953x.c
> @@ -47,9 +47,6 @@ struct pca953x_chip_ngpio {
> static struct pca953x_chip_ngpio pca953x_chip_ngpios[] =
> CONFIG_SYS_I2C_PCA953X_WIDTH;
>
> -#define NUM_CHIP_GPIOS (sizeof(pca953x_chip_ngpios) / \
> - sizeof(struct pca953x_chip_ngpio))
> -
> /*
> * Determine the number of GPIO pins supported. If we don't know we assume
> * 8 pins.
> @@ -58,7 +55,7 @@ static int pca953x_ngpio(uint8_t chip)
> {
> int i;
>
> - for (i = 0; i < NUM_CHIP_GPIOS; i++)
> + for (i = 0; i < ARRAY_SIZE(pca953x_chip_ngpios); i++)
> if (pca953x_chip_ngpios[i].chip == chip)
> return pca953x_chip_ngpios[i].ngpio;
Absolutelly
Acked-by: Marek Vasut <marex at denx.de>
Best regards,
Marek Vasut
More information about the U-Boot
mailing list