[U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

Albert ARIBAUD albert.u.boot at aribaud.net
Sun Jun 23 09:07:14 CEST 2013


Hi Harninder,

On Mon, 17 Jun 2013 17:18:32 +0530, Harninder Rai
<harninder.rai at freescale.com> wrote:

> Keep the value of CONFIG_BOOTDELAY as -1 to disable autoboot
> 
> Signed-off-by: Harninder Rai <harninder.rai at freescale.com>
> ---
>  include/configs/BSC9131RDB.h |    1 +
>  include/configs/BSC9132QDS.h |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h
> index fd076e0..c56b119 100644
> --- a/include/configs/BSC9131RDB.h
> +++ b/include/configs/BSC9131RDB.h
> @@ -393,6 +393,7 @@ extern unsigned long get_sdram_size(void);
>  #define CONFIG_UBOOTPATH	"u-boot.bin" /* U-Boot image on TFTP server */
>  
>  #define CONFIG_BAUDRATE		115200
> +#define CONFIG_BOOTDELAY	-1 /* Disable autoboot */
>  
>  #define	CONFIG_EXTRA_ENV_SETTINGS				\
>  	"netdev=eth0\0"						\
> diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h
> index 9d15d0e..d54900a 100644
> --- a/include/configs/BSC9132QDS.h
> +++ b/include/configs/BSC9132QDS.h
> @@ -607,6 +607,7 @@ combinations. this should be removed later
>  #define CONFIG_UBOOTPATH	"u-boot.bin"
>  
>  #define CONFIG_BAUDRATE		115200
> +#define CONFIG_BOOTDELAY	-1 /* Disable autoboot */
>  
>  #ifdef CONFIG_SDCARD
>  #define CONFIG_DEF_HWCONFIG	"hwconfig=usb1:dr_mode=host,phy_type=ulpi\0"

Plase fix commit message: you're not simply adding a boot delay flag,
you're in fact disabling autoboot, which is quite different.

Also, when touching on a board's code, you should Cc: the board's
maintainer(s). Please do so for V2 of your patch -- and if you get a
non-delivery status (e.g. a maintainer's mail address does not exist any
more), please follow up on your patch submission to let us know.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list