[U-Boot] [PATCH V2 1/9] Validate dtc is new enough

Stephen Warren swarren at wwwdotorg.org
Tue Jun 25 16:47:34 CEST 2013


On 06/24/2013 06:45 PM, Simon Glass wrote:
> Hi Stephen,
> 
> On Mon, Jun 24, 2013 at 8:43 AM, Stephen Warren <swarren at wwwdotorg.org
> <mailto:swarren at wwwdotorg.org>> wrote:
> 
>     From: Stephen Warren <swarren at nvidia.com <mailto:swarren at nvidia.com>>
> 
>     Subsequent patches assume that dtc supports various recent features.
>     These are available in dtc 1.4.0. Validate that dtc is at least that
>     version.
> 

> Acked-by: Simon Glass <sjg at chromium.org <mailto:sjg at chromium.org>>
> 
> See note below.

>     diff --git a/Makefile b/Makefile

>     -$(obj)u-boot.dtb:      $(obj)u-boot
>     +$(obj)u-boot.dtb:      checkdtc $(obj)u-boot
> 
> 
> Any reason this is not in dts/Makefile? Still this is fine.

I guess that would have worked too. One advantage of the current
placement is that make just happens to evaluate the rule really early
(at least with more than -j1!), so you don't build a lot before it
errors out, thus giving you quicker feedback. It also keeps all the tool
version checks in one file; perhaps easier maintenance?


More information about the U-Boot mailing list