[U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

[Sascha Silbe]

Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com> writes:

> Either orion_spi as it was named originally, or mv_spi as Prafulla
> suggested. Then move mpp (pinctrl) from kirkwood_spi to corresponding
> boards, switch to orion_/mv_spi, and remove kirkwood_spi.
>
> I suggest orion_spi, but Prafulla had his word so it should be mv_spi
> I guess.

I've given it a try and modified the Kirkwood GPIO and SPI drivers
rather than duplicating their code. As I neither know the Dove SoCs nor
have any hardware using them, I don't feel comfortable merging this with
any existing orion code. For similar reasons and also for a lack of time
I've left the MPP support code in place, just protected with
CONFIG_KIRKWOOD.

As for the naming: there's already a GPIO driver called mvgpio that
looks quite different from the Kirkwood / Dove one. Naming the latter
one mv_gpio would work for the build tools, but needlessly cause
confusion to developers. Therefore I chose to keep the current names of
the Kirkwood drivers (kw_gpio, kirkwood_spi). If anyone has a better
suggestion, I'm happy to change the names.

Sebastian, does the resulting code still match your intentions or would
you like me to remove your Signed-off-by from those two patches when
posting the updated patch series?

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130625/659476ff/attachment.pgp>