[U-Boot] [PATCH] dfu:ext4:fix Fix ext4{read|write} command formatting

Lukasz Majewski l.majewski at samsung.com
Wed Jun 26 17:27:05 CEST 2013


On Wed, 26 Jun 2013 11:05:31 -0400, Tom Rini wrote:

> On Wed, Jun 26, 2013 at 04:41:28PM +0200, Lukasz Majewski wrote:
> > Hi Tom,
> > 
> > > In the following commit:
> > > "dfu: Support larger than memory transfers."
> > > SHA1: ea2453d56b8860dbd18a3c517531ffc8dcb5c839
> > > 
> > > The ext4{read|write} command formatting has been changed. It
> > > removed a mandatory [sizebytes] parameter.
> > > 
> > > It prevented from ext4 update via dfu. This commit restored the
> > > previous behaviour.
> > 
> > Tom, please drop this patch, since it only fixes DFU eMMC write.
> > 
> > Unfortunately after dfu.c code changes to support NAND and arbitrary
> > files transmission, the eMMC ext4 read needs to be fixed.
> > 
> > I will prepare one patch set, which fixes read and write.
> 
> Ouch, sorry.  I thought I had tested those cases still.
> 

With RAW_ADDR from very beginning, we can read chunk by chunk when
proper request from DFU arrives. 

With e.g. DFU_FS_EXT4 we first need to read all data from file system
to a buffer (dfu_buf) and then give it to DFU gadget piece by piece.

I will fix this and share patches.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list