[U-Boot] [PATCH v2 15/21] Refactor the bootm command to reduce code duplication

[Tom Rini]

On Thu, Jun 27, 2013 at 03:40:36PM +0200, Stefan Roese wrote:
> Hi Simon,
> 
> On 06/11/2013 08:14 PM, Simon Glass wrote:
> > At present the bootm code is mostly duplicated for the plain 'bootm'
> > command and its sub-command variant. This makes the code harder to
> > maintain and means that changes must be made to several places.
> > 
> > Introduce do_bootm_states() which performs selected portions of the bootm
> > work, so that both plain 'bootm' and 'bootm <sub_command>' can use the
> > same code.
> > 
> > Additional duplication exists in bootz, so tidy that up as well. This
> > is not intended to change behaviour, apart from minor fixes where the
> > previously-duplicated code missed some chunks of code.
> > 
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> 
> Simon, this patch breaks bootm (at least on powerpc), while booting an
> compressed uImage (with DT). It just hangs while decompressing the
> kernel image:

I swear I had boot tested a kernel on beaglebone with the series, but I
see the similar behavior right now, on ARM.  I also see it with FIT images
(which I think I'm building correctly, but they go far off into the
weeds and are ignoring entry/load values).  It's not a hang, it's return
to prompt.  If you follow with a bootm go, it hangs.  With or without
CONFIG_SYS_GENERIC_BOARD set.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130627/21b0e36c/attachment.pgp>