[U-Boot] [PATCH 2/3] mx6qsabresd: Document the mapping of USDHC[2-4]

[Otavio Salvador]

On Sat, Mar 2, 2013 at 7:14 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sat, Mar 2, 2013 at 6:49 PM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>
> No commit log. It is really hard for someone to understand why you
> need this patch if you do not explain it.

Right; I can extend it.

>> ---
>>  board/freescale/mx6qsabresd/mx6qsabresd.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/board/freescale/mx6qsabresd/mx6qsabresd.c b/board/freescale/mx6qsabresd/mx6qsabresd.c
>> index 3c00023..c334403 100644
>> --- a/board/freescale/mx6qsabresd/mx6qsabresd.c
>> +++ b/board/freescale/mx6qsabresd/mx6qsabresd.c
>> @@ -26,6 +26,7 @@
>>  #include <asm/errno.h>
>>  #include <asm/gpio.h>
>>  #include <asm/imx-common/iomux-v3.h>
>> +#include <asm/imx-common/boot_mode.h>
>>  #include <mmc.h>
>>  #include <fsl_esdhc.h>
>>  #include <miiphy.h>
>> @@ -164,18 +165,21 @@ int board_mmc_init(bd_t *bis)
>>
>>         for (i = 0; i < CONFIG_SYS_FSL_USDHC_NUM; i++) {
>>                 switch (i) {
>> +               /* SD2 - mmc0 */
>
> This mapping is dependent on the kernel. Does it make sense to
> describe this in the bootloader?

It does not matter if it changes in the kernel later; I'd like to have
it here so people can know which one to use if need to choose one.

It is hard to know which one the bootloader will use without it.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br