[U-Boot] [PATCH 5/8] Add TI816X cpu definitions

Peter Korsgaard jacmet at sunsite.dk
Thu Mar 28 22:24:17 CET 2013


>>>>> "TENART" == TENART Antoine <atenart at adeneo-embedded.com> writes:

 TENART> ---
 TENART>  arch/arm/include/asm/arch-am33xx/cpu.h        |    4 +
 TENART>  arch/arm/include/asm/arch-am33xx/cpu_ti816x.h |  269 +++++++++++++++++++++++++
 TENART>  arch/arm/include/asm/emif.h                   |    4 +
 TENART>  3 files changed, 277 insertions(+)
 TENART>  create mode 100644 arch/arm/include/asm/arch-am33xx/cpu_ti816x.h

 TENART> diff --git a/arch/arm/include/asm/arch-am33xx/cpu.h b/arch/arm/include/asm/arch-am33xx/cpu.h
 TENART> index 13c0667..34b3aa9 100644
 TENART> --- a/arch/arm/include/asm/arch-am33xx/cpu.h
 TENART> +++ b/arch/arm/include/asm/arch-am33xx/cpu.h
 TENART> @@ -25,6 +25,10 @@
 
 TENART>  #include <asm/arch/hardware.h>
 
 TENART> +#if defined(CONFIG_TI816X)
 TENART> +#include <asm/arch/cpu_ti816x.h>
 TENART> +#endif
 TENART> +
 TENART>  #define BIT(x)				(1 << x)
 TENART>  #define CL_BIT(x)			(0 << x)
 
 TENART> diff --git a/arch/arm/include/asm/arch-am33xx/cpu_ti816x.h b/arch/arm/include/asm/arch-am33xx/cpu_ti816x.h
 TENART> new file mode 100644
 TENART> index 0000000..b4a13a8
 TENART> --- /dev/null
 TENART> +++ b/arch/arm/include/asm/arch-am33xx/cpu_ti816x.h
 TENART> @@ -0,0 +1,269 @@
 TENART> +/*
 TENART> + * cpu_ti816x.h
 TENART> + *
 TENART> + * Copyright (C) 2013, Adeneo Embedded <www.adeneo-embedded.com>
 TENART> + * Antoine Tenart, <atenart at adeneo-embedded.com>
 TENART> + *
 TENART> + * Based on TI-PSP-04.00.02.14 :
 TENART> + *
 TENART> + * (C) Copyright 2006
 TENART> + * Texas Instruments, <www.ti.com>
 TENART> + *
 TENART> + * See file CREDITS for list of people who contributed to this
 TENART> + * project.
 TENART> + *
 TENART> + * This program is free software; you can redistribute it and/or
 TENART> + * modify it under the terms of the GNU General Public License as
 TENART> + * published by the Free Software Foundation; either version 2 of
 TENART> + * the License, or (at your option) any later version.
 TENART> + *
 TENART> + * This program is distributed in the hope that it will be useful,
 TENART> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 TENART> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 TENART> + * GNU General Public License for more details.
 TENART> + *
 TENART> + * You should have received a copy of the GNU General Public License
 TENART> + * along with this program; if not, write to the Free Software
 TENART> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 TENART> + * MA 02111-1307 USA
 TENART> + *
 TENART> + */
 TENART> +
 TENART> +#ifndef _TI816X_CPU_H
 TENART> +#define _TI816X_CPU_H
 TENART> +
 TENART> +#include <asm/arch/hardware.h>
 TENART> +
 TENART> +/* Timer registers */
 TENART> +#define TIMER_TCLR			0x38		/* Timer control register */
 TENART> +#define TIMER_TCRR			0x3C		/* Timer counter register */
 TENART> +#define TIMER_TLDR			0x40		/* Timer load value register*/
 TENART> +

Are these defines all needed? As far as I can see from skimming the
series, they aren't referenced anywhere.

 TENART> diff --git a/arch/arm/include/asm/emif.h b/arch/arm/include/asm/emif.h
 TENART> index ed251ec..a7b938c 100644
 TENART> --- a/arch/arm/include/asm/emif.h
 TENART> +++ b/arch/arm/include/asm/emif.h
 TENART> @@ -521,7 +521,11 @@
 TENART>  #define SDRAM_CONFIG_EXT_RD_LVL_4_SAMPLES	0x000001A7
 
 TENART>  /* DMM */
 TENART> +#if defined(CONFIG_TI816X)
 TENART> +#define DMM_BASE			0x4E000000
 TENART> +#else
 TENART>  #define DMM_BASE			0x4E000040
 TENART> +#endif

I don't think that's right. Matt's series uses DMM_BASE to refer to the
lisa registers, which are offset 0x40 from the DMM region, so I think
you can drop this.

-- 
Bye, Peter Korsgaard


More information about the U-Boot mailing list