[U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop

Marek Vasut marex at denx.de
Mon Nov 4 12:50:21 CET 2013


Hi Stefano,

> Hi Marek,
> 
> On 02/11/2013 18:23, Marek Vasut wrote:
> > +			if (!timeout) {
> > +				debug("MXS I2C: Failed receiving data!\n");
> > +				return -EINVAL;
> > +			}
> > +
> 
> This is a real error and not a debug information. IMHO it should be
> better to print the error unconditionally with puts/printf, reporting
> that the timer elapsed.

Returning -EINVAL will make the i2c stack trigger an output, so having it 
duplicated here is pointless I believe.

Best regards,
Marek Vasut


More information about the U-Boot mailing list