[U-Boot] [PATCH 0/4] udoo: Improve stability of DDR3 setting

[Giuseppe Pagano]

Hi Stefano,

On Thu, 2013-11-07 at 09:12 +0100, Stefano Babic wrote:
> Hi Giuseppe,
> 
> On 06/11/2013 21:30, Giuseppe Pagano wrote:
> > Move udoo configuration files to board/udoo/ folder.
> > Align clock configuration and DDR3 calibration to Seco suggested value
> > to increase system stability.
> 
> There are some basic issues with your patchset. First, patches are
> corrupted by your editor and/or by your mailer and cannot be applied.
.....
> Instead of generating the patches with diff, use "git format-patch", and
> then submit the patches to the mailing list with "git send-email". 

Sorry, I used vim and imported patch as a file in evolution, I
understood too late that I also need to change Format from "normal" to
"preformatted". In the future I will use "git send-email".

> 
> Please take a look at the rules to submit patches :
> 
> 	http://www.denx.de/wiki/U-Boot/Patches

Sure, I read it, nevertheless I made lots of errors. This was my first
submit..sorry

> Do not fix multiple issues in the same patch if not strictly needed. The
> commit message is misleading: you say you are moving the configuration
> files, but they are not moved (they can't because they belong to
> nitrogen) and new files are generated.

Maybe I was wrong in writing "move configuration files.." 

I think [PATCH 0/4] can be consider an atomical change: Fabio first uDoo
support adopt nitrogenx register setting for DDR3, clock, muxing, etc

uDoo schematics is rather different from nitrogen6x, and it needs
customized setting for most of the register (as every platform). It
takes too long describe every single new setting. 
Previous configuration was very unstable and adopting those settings
uDoo board has frequently crash. Seco had validated new setting I'm
going to propose using "climatic room" and various tests, which stressed
system and cpu for about 7 days long cycles. 

> 
> I do not understand what you mean with "Align clock configuration and
> DDR3 calibration to Seco suggested value". Please explain: which values
> are wrong, what you have fix with your patch.

See above.

> If you make change to a board, you should send your patches in CC to the
> board maintainer, too (for udoo, Fabio: I put him in CC).

Fabio was abreast of this changes, but not in cc. I'll use CC in next
post.

> 
> > Signed-off-by: Giuseppe Pagano <giuseppe.pagano at seco.com>
> > Cc: sbabic at denx.de
> > 
> > ...

> 
> Best regards,
> Stefano Babic

Best Regards,
Giuseppe Pagano