[U-Boot] [PATCH] designware_i2c: remove 10msec delay in i2c_xfer_finish

Alexey Brodkin Alexey.Brodkin at synopsys.com
Thu Nov 7 14:52:33 CET 2013


This delay applies to any data transfer on I2C bus.

For example 1kB data read with per-byte access (which happens if
environment is stored in I2C EEPROM) takes more than 10 seconds.

Moreover data bus driver has to care about bus state and data transfer,
but not about internal states of attached devices.

Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>

Cc: Tom Rini <trini at ti.com>
cc: Armando Visconti <armando.visconti at st.com>
Cc: Stefan Roese <sr at denx.de>
Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
Cc: Heiko Schocher <hs at denx.de>
Cc: Vipin KUMAR <vipin.kumar at st.com>
Cc: Tom Rix <Tom.Rix at windriver.com>
Cc: Mischa Jonker <mjonker at synopsys.com>
---
 drivers/i2c/designware_i2c.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
index c5c6015..cb2ac04 100644
--- a/drivers/i2c/designware_i2c.c
+++ b/drivers/i2c/designware_i2c.c
@@ -249,9 +249,6 @@ static int i2c_xfer_finish(void)
 
 	i2c_flush_rxfifo();
 
-	/* Wait for read/write operation to complete on actual memory */
-	udelay(10000);
-
 	return 0;
 }
 
-- 
1.8.4.2



More information about the U-Boot mailing list