[U-Boot] [PATCH 05/14] ARM: AM43XX: board: add support for reading onboard EEPROM

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/07/2013 03:56 PM, Vaibhav Bedia wrote:
> Hi Tom,
> 
> On Wed, Nov 6, 2013 at 4:37 PM, Tom Rini <trini at ti.com> wrote:
>>>>>> +
>>>>>> +       if (header->magic != 0xEE3355AA) {
>>>>>
>>>>> Why is the header the same as AM335x? Shouldn't it be something
>>>>> like 0xEE3344AA or whatever?
>>>> No, the header is still same. It is 0xEE3355AA.
>>>>
>>>
>>> My question was why ;)
>>> What's the point of adding the same magic value for a different SoC?
>>> Unless there's a good reason for doing so i think this needs to be fixed
>>> in the EEPROM programmer.
>>
>> A magic value is sufficiently magical, I don't think we'll get anyone to
>> change it at this point.
> 
> With almost half a dozen of AM335x board variants floating around this
> thing is bound to cause problems eventually. The EEPROM format
> can simply be updated to fix this. If there's a big resistance in doing
> this then we might as well live with it - but i would at least ask once ;)

The thing is, customers drop the EEPROM or come up with their own, see
the Siemens am335x boards :)

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSfADXAAoJENk4IS6UOR1WRa0P/1EMaiNOZsztbkdosA+Gja5y
/FDdvJl8fWrKKMY0gBUNIplFNev2cDdOyb0EdglD77oinYM8cpdYHkh1rhZEv7rA
kvx5rFZ0iOftuavbgtUEBcTs2/oLbFjKZV8ajCkwuFig6E1XY49yeT9obsB9UKxG
uBYIs75SYBPZg/8RzDlQbwpyBR/3cSwRQ9t61p21lQVnZvenIwNPhVxCg++jxtdT
i0IuzraMwcdUXKIBoBkE6Lu+vYgbi4yWcrPIrllxo5C3vRkw9ua6rRHB9qTG60xM
V02CSxm9UTfrg4yMlBZHMkPDAHcbAirV4+z70vMdqsffzMhGspL3/Lo8+bf6FD31
xnlws8IVJTLjNTLL/ZZ6POcPXI2rHsLkdfVQoXYWVBVmn5ZHvfrCEL2ahkYBG40Y
y2rzyw/QiFCZz8GXPHNV7NNDaVTaasw7ph7dJ03/a3yMBJJNIK7OV3EdR22dtgUe
a2734X2DWbPQtdovkH5YQMULXi5pYH6aCXMbcPGsGWVN8HZXuEOdmNdWkdFyoD4W
/l8vx63X5BdUCsrbahp6KI9Es4AZN/QbNGbn5oLSkf/qVDdJTxW3RrZ/wcgk+r3I
F7ufYYetQi0nOE+2ri0ayFgZNNqNCbUZKeZEuEMzUNXwPfY4CZDTov3fk2C4rnfk
PewbVnXTpc2lnUyjxD1v
=B5PZ
-----END PGP SIGNATURE-----