[U-Boot] [PATCH 2/3] gpio_led: check gpio_request() return value

Igor Grinberg grinberg at compulab.co.il
Fri Nov 8 00:03:51 CET 2013


Add a check for the gpio_request() function return value and do not try
to configure the GPIO if the gpio_request() call fails.
Also, print an error message indicating the gpio_request() has failed.

Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
---
 drivers/misc/gpio_led.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c
index 3fedddc..de20419 100644
--- a/drivers/misc/gpio_led.c
+++ b/drivers/misc/gpio_led.c
@@ -11,7 +11,11 @@
 
 void __led_init(led_id_t mask, int state)
 {
-	gpio_request(mask, "gpio_led");
+	if (gpio_request(mask, "gpio_led") != 0) {
+		printf("%s: failed requesting GPIO%lu!\n", __func__, mask);
+		return;
+	}
+
 	gpio_direction_output(mask, state == STATUS_LED_ON);
 }
 
-- 
1.8.1.5



More information about the U-Boot mailing list