[U-Boot] [PATCH v1 3/6] arm: pxa: move SP check from start.S to cpuinfo.c

Marek Vasut marex at denx.de
Sat Nov 9 03:27:23 CET 2013


Dear Albert ARIBAUD,

> PXA start.S has a PXA (variant) specific check in
> start.S. Move it to cpuinfo.c.
> 
> Signed-off-by: Albert ARIBAUD <albert.u.boot at aribaud.net>

Either way WFM

Acked-by: Marek Vasut <marex at denx.de>

> ---
>  arch/arm/cpu/pxa/cpuinfo.c | 6 ++++++
>  arch/arm/cpu/pxa/start.S   | 6 ------
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/pxa/cpuinfo.c b/arch/arm/cpu/pxa/cpuinfo.c
> index 9d16079..17d8be5 100644
> --- a/arch/arm/cpu/pxa/cpuinfo.c
> +++ b/arch/arm/cpu/pxa/cpuinfo.c
> @@ -11,6 +11,12 @@
>  #include <errno.h>
>  #include <linux/compiler.h>
> 
> +#ifdef CONFIG_CPU_PXA25X
> +#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800)
> +#error "Init SP address must be set to 0xfffff800 for PXA250"
> +#endif
> +#endif
> +
>  #define	CPU_MASK_PXA_PRODID	0x000003f0
>  #define	CPU_MASK_PXA_REVID	0x0000000f
> 
> diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S
> index ae0d13c..eb3243a 100644
> --- a/arch/arm/cpu/pxa/start.S
> +++ b/arch/arm/cpu/pxa/start.S
> @@ -23,12 +23,6 @@
>  #include <config.h>
>  #include <version.h>
> 
> -#ifdef CONFIG_CPU_PXA25X
> -#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800)
> -#error "Init SP address must be set to 0xfffff800 for PXA250"
> -#endif
> -#endif
> -
>  .globl _start
>  _start: b	reset
>  #ifdef CONFIG_SPL_BUILD

Best regards,
Marek Vasut


More information about the U-Boot mailing list