[U-Boot] [PATCH v3 09/18] malta: support for coreFPGA6 boards

Paul Burton paul.burton at imgtec.com
Mon Nov 11 11:32:31 CET 2013



On 10/11/13 20:07, Marek Vasut wrote:
> Dear Paul Burton,
>
>> This patch adds support for running on Malta boards using coreFPGA6
>> core cards, including support for the msc01 system controller used
>> with them. The system controller is detected at runtime allowing one
>> U-boot binary to run on a Malta with either.
>>
>> Due to the PCI I/O base differing between Maltas using gt64120 & msc01
>> system controllers, the UART setup is modified slightly. A second UART
>> is added so that there is one pointing at the correct address for each
>> system controller. The Malta board then defines its own
>> default_serial_console function to select the correct one at runtime.
>> The incorrect UART will simply not function.
>>
>> Tested on:
>>    - A coreFPGA6 Malta running interAptiv and proAptiv bitstreams, both
>>      with and without an L2 cache.
>>    - QEMU.
>>
>> Signed-off-by: Paul Burton <paul.burton at imgtec.com>
>> ---
>> Changes in v3:
>>    - rebase atop master
>>    - remove commit message note about not working in QEMU, this does work
>>      in older QEMU versions as noted by Gabor Juhos
>>
>> Changes in v2:
>>    - rebased after malta moved to board/imgtec/malta
>>    - removed unused status variable from msc01_config_access
>> ---
>>   arch/mips/include/asm/malta.h      |  35 ++++++--
>>   board/imgtec/malta/lowlevel_init.S | 164
>> ++++++++++++++++++++++++++++++++++++- board/imgtec/malta/malta.c         |
>> 126 ++++++++++++++++++++++++++-- drivers/pci/Makefile               |   1
>> +
>>   drivers/pci/pci_msc01.c            | 125 ++++++++++++++++++++++++++++
>>   include/configs/malta.h            |   4 +-
>>   include/msc01.h                    | 135 ++++++++++++++++++++++++++++++
>>   include/pci_ids.h                  |   3 +
>>   include/pci_msc01.h                |  17 ++++
>>   9 files changed, 594 insertions(+), 16 deletions(-)
>>   create mode 100644 drivers/pci/pci_msc01.c
>>   create mode 100644 include/msc01.h
>>   create mode 100644 include/pci_msc01.h
>>
>> diff --git a/arch/mips/include/asm/malta.h b/arch/mips/include/asm/malta.h
>> index d4d44a2..0b50a66 100644
>> --- a/arch/mips/include/asm/malta.h
>> +++ b/arch/mips/include/asm/malta.h
>
> You are missing license in some files.
>
> Best regards,
> Marek Vasut
>

Which files? The only files this patch adds are:

   drivers/pci/pci_msc01.c
   include/msc01.h
   include/pci_msc01.h

...and all 3 of them contain GPL-2.0+ SPDX tags.

Thanks,
     Paul



More information about the U-Boot mailing list