[U-Boot] [PATCH] MIPS: use CONFIG_SYS_TEXT_BASE in relocation calculations

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Mon Nov 11 20:36:01 CET 2013


2013/11/11 Gabor Juhos <juhosg at openwrt.org>:
> The relocation code uses the CONFIG_SYS_MONITOR_BASE
> constant for calculating the reserved memory size and
> relocation offset values. Along with these predefined
> values the code also uses several other constants which
> are computed by the linker from the CONFIG_SYS_TEXT_BASE
> value. Due to this, the relocation code works incorreclty
> if the CONFIG_SYS_TEXT_BASE and CONFIG_SYS_MONITOR_BASE
> values are different.

to be consistent with all other architectures, we should keep
CONFIG_SYS_MONITOR_BASE. I think it is neither valid nor intentional
to use a value different from CONFIG_SYS_TEXT_BASE. Instead we should
change include/configs/malta.h:

-#define CONFIG_SYS_MONITOR_BASE                CONFIG_SYS_FLASH_BASE
+#define CONFIG_SYS_MONITOR_BASE                CONFIG_SYS_TEXT_BASE


Comments?

-- 
- Daniel


More information about the U-Boot mailing list