[U-Boot] u-boot gerrit server

Scott Wood scottwood at freescale.com
Wed Nov 13 23:39:07 CET 2013


On Tue, 2013-11-12 at 10:24 -0800, Vadim Bendebury wrote:
> On Tue, Nov 12, 2013 at 10:07 AM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
> > On Tue, Nov 12, 2013 at 3:30 PM, Albert ARIBAUD
> > <albert.u.boot at aribaud.net> wrote:
> >> Hi Otavio,
> >>
> >> On Tue, 12 Nov 2013 15:16:15 -0200, Otavio Salvador
> >> <otavio at ossystems.com.br> wrote:
> >>
> >>> Hello Albert,
> >>>
> >>> On Tue, Nov 12, 2013 at 3:13 PM, Albert ARIBAUD
> >>> <albert.u.boot at aribaud.net> wrote:
> >>> > On Tue, 12 Nov 2013 15:00:06 -0200, Otavio Salvador
> >>> > <otavio at ossystems.com.br> wrote:
> >>> >
> >>> >> On Tue, Nov 12, 2013 at 2:55 PM, Vadim Bendebury (вб)
> >>> >> <vbendeb at google.com> wrote:
> >>> >> > On Tue, Nov 12, 2013 at 8:47 AM, Otavio Salvador
> >>> >> > <otavio at ossystems.com.br> wrote:
> >>> >> >> Besides, how people will 'transfer' one patch from one tree to
> >>> >> >> another? This will happen quite often as someone mistakenly sending a
> >>> >> >> patch for the wrong tree or custodians wanting the set to go together
> >>> >> >> in a single merge...
> >>> >> >>
> >>> >> >
> >>> >> > How is it handled today? Gerrit is after all just a means of keeping
> >>> >> > track of patches in a more efficient way, the rest could be similar to
> >>> >> > what is in use now, or enhanced using gerrit's features.
> >>> >>
> >>> >> Currently it is just reassigned in Patchwork; using multiple trees
> >>> >> will complicate this.
> >>> >
> >>> > How about one branch per custodian? At my previous job we had a couple
> >>> > branches, one per distinct "product".
> >>>
> >>> I am not aware of a way to 'transfer' a patch from one branch to another.
> >>
> >> There would not be such transfers -- we don't do this right now with
> >> our trees. We do merge requests, which means pulling two custodian repos
> >> into the same working repo, doing a merge between what are now two
> >> custodian branches, and pushing the result back onto one of the
> >> custodian trees.
> >>
> >> So here, if there is one branch per custodian, what we would need
> >> is the ability to merge one custodian branch into another.
> >
> > Right but currently you are not 'denied' to review a patch someone
> > didn't put for you. The custodians as done 'on-the-fly' as each
> > custodian takes his duties and process the patches and apply them,
> > later updating patchwork.
> >
> > On the 'new Gerrit' workflow, if it is assigned for a branch/tree and
> > this is mistakenly done, how it will be done?
> >
> 
> the patch can always be abandoned on gerrit, so no problem there. As
> for moving it to the right tree - either the original submitter could
> resubmit it,

And the custodians would have to carefully check that it was actually
the same patch that the previous custodian acked to go through the
second custodian's tree...

-Scott





More information about the U-Boot mailing list