[U-Boot] [[PATCH v2]pandaboard: 1/1] Modification of Elpida DDR2 RAM for Pandaboard-ES Rev B3
Tom Rini
trini at ti.com
Thu Nov 14 20:49:27 CET 2013
On Thu, Nov 14, 2013 at 01:41:48PM -0600, Nishanth Menon wrote:
> On 11/14/2013 04:06 AM, Hardik wrote:
> > From: Hardik Patel <hardik.patel at volansystech.com>
> Add some details about the change -> commit message is usually
> suggested as a good thing to have.
>
> [...]
> > diff --git a/board/ti/panda/panda.c b/board/ti/panda/panda.c
> > index c104024..5a7f80a 100644
> > --- a/board/ti/panda/panda.c
> > +++ b/board/ti/panda/panda.c
> > @@ -122,6 +122,30 @@ int get_board_revision(void)
> > return board_id;
> > }
> >
> > +/*
> > +* Routine: is_panda_es_rev_b3
> > +* Description: Detect if we are running on B3 version of ES panda board,
> > +* This can be done by reading the level of GPIO 171
Using Nishanth's reply since I had this one handy. There's trailing
whitespace here, which the gerrit test setup makes very visible, but
also shows that checkpatch.pl wasn't run before submission, so please
fix that in v3. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131114/9c99b5e8/attachment.pgp>
More information about the U-Boot
mailing list