[U-Boot] [PATCH] ARM: OMAP4: Fix bug in omap4470_volts struct

Lubomir Popov lpopov at mm-sol.com
Wed Nov 20 14:32:17 CET 2013


The struct incorrectly referenced SMPS1 for all three power
domains. Fixed this by using SMPS2 and SMPS5 as appropriate.

Add some comments and choose voltage values that correspond
to voltage selection codes.

Signed-off-by: Lubomir Popov <l-popov at ti.com>
---
  arch/arm/cpu/armv7/omap4/hw_data.c |   12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap4/hw_data.c b/arch/arm/cpu/armv7/omap4/hw_data.c
index 6a225c8..1b2f439 100644
--- a/arch/arm/cpu/armv7/omap4/hw_data.c
+++ b/arch/arm/cpu/armv7/omap4/hw_data.c
@@ -288,17 +288,21 @@ struct vcores_data omap4460_volts = {
      .mm.pmic = &twl6030,
  };

+/*
+ * Take closest integer part of the mV value corresponding to a TWL6032 SMPS
+ * voltage selection code. Aligned with OMAP4470 ES1.0 OCA V.0.7.
+ */
  struct vcores_data omap4470_volts = {
-    .mpu.value = 1200,
+    .mpu.value = 1202,
      .mpu.addr = SMPS_REG_ADDR_SMPS1,
      .mpu.pmic = &twl6030,

      .core.value = 1126,
-    .core.addr = SMPS_REG_ADDR_SMPS1,
+    .core.addr = SMPS_REG_ADDR_SMPS2,
      .core.pmic = &twl6030,

-    .mm.value = 1137,
-    .mm.addr = SMPS_REG_ADDR_SMPS1,
+    .mm.value = 1139,
+    .mm.addr = SMPS_REG_ADDR_SMPS5,
      .mm.pmic = &twl6030,
  };

-- 
1.7.9.5



More information about the U-Boot mailing list