[U-Boot] [PATCH V2 01/14] ARM: AM43xx: Update the base addresses of modules

Lokesh Vutla lokeshvutla at ti.com
Mon Nov 25 10:26:22 CET 2013


On Friday 22 November 2013 01:50 AM, Vaibhav Bedia wrote:
> Hi Lokesh,
> 
> On Thu, Nov 21, 2013 at 1:18 AM, Lokesh Vutla <lokeshvutla at ti.com> wrote:
> [...]
>> +#define CM_DPLL                                0x44DF4200
>> +#define CM_RTC                         0x44df8500
>>
> 
> nit: CM_RTC address should be in caps for the sake of consistency
OK ll change it.
> 
>>  #define PRM_RSTCTRL                    (PRCM_BASE + 0x4000)
>>  #define PRM_RSTST                      (PRM_RSTCTRL + 4)
>> diff --git a/arch/arm/include/asm/arch-am33xx/hardware_ti814x.h b/arch/arm/include/asm/arch-am33xx/hardware_ti814x.h
>> index 4509a23..9080b6f 100644
>> --- a/arch/arm/include/asm/arch-am33xx/hardware_ti814x.h
>> +++ b/arch/arm/include/asm/arch-am33xx/hardware_ti814x.h
>> @@ -27,6 +27,8 @@
>>  #define PRCM_BASE                      0x48180000
>>  #define CM_PER                         0x44E00000
>>  #define CM_WKUP                                0x44E00400
>> +#define CM_DPLL                                0x44E00500
>> +#define CM_RTC                         0x44E00800
>>
> 
> Looking at these address i strongly suspect the CM_XXX ones are wrong
> for the TI81xx
> family. Does this really match with the TRM?
Yes, you are correct. TI814x code doesn't use these defines at all.
Ill drop these.

Thanks
Lokesh
> 
> Regards,
> Vaibhav
> 



More information about the U-Boot mailing list