[U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f()

Simon Glass sjg at chromium.org
Thu Nov 28 02:41:46 CET 2013


Hi,

On 27 November 2013 18:38, Masahiro Yamada <yamada.m at jp.panasonic.com>wrote:

> Hello Tom, Albert.
> (I'm CCing Simon)
>
> > Some code in board_init_f that dates back to the initial relocation
> > support had if/else for PRELOADER (which became SPL_BUILD) about setting
> > the stack pointer.  But, board.c is never built for CONFIG_SPL_BUILD
> > now, so this really makes no sense.  Drop this section.
> >
> > Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> > Signed-off-by: Tom Rini <trini at ti.com>
>
> Do you have any idea  when ARM architecture can completely
> switch to the generic board?
>
> If the generic board has the same behavior as arch/arm/lib/board.c,
> how about deleting arch/arm/lib/board.c rather than maintaining it.
>

We need to test a few more board types I think. Perhaps in the interim we
could print a warning message that the old board.c is going away in 6
months?

Regards,
Simon


>
>
> Best Regards
> Masahiro Yamada
>
>


More information about the U-Boot mailing list