[U-Boot] [PATCH] Makefile: delete unnecessary CPPFLAGS settings

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Nov 28 10:31:59 CET 2013


Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
---

Note that changing CPPFLAGS locally is meaningless.

$(CPPFLAGS) is evaluated around line 260 of $(TOPDIR)/config.mk:

    CFLAGS := $(CPPFLAGS) -Wall -Wstrict-prototypes

$(TOPDIR)/config.mk is included at the top of
sub makefiles, which is before adding CPPFLAGS locally.

Please be aware that GNU make has the two different flavor
of substition operator, ":=" and "=".


 board/freescale/common/p_corenet/Makefile | 2 --
 common/Makefile                           | 2 --
 2 files changed, 4 deletions(-)

diff --git a/board/freescale/common/p_corenet/Makefile b/board/freescale/common/p_corenet/Makefile
index 889c493..1f399d2 100644
--- a/board/freescale/common/p_corenet/Makefile
+++ b/board/freescale/common/p_corenet/Makefile
@@ -5,8 +5,6 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-CPPFLAGS += -I$(TOPDIR)
-
 obj-y			+= law.o
 obj-$(CONFIG_PCI)	+= pci.o
 obj-y			+= tlb.o
diff --git a/common/Makefile b/common/Makefile
index 74404be..d12cba5 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -230,8 +230,6 @@ obj-$(CONFIG_FIT_SIGNATURE) += image-sig.o
 obj-y += memsize.o
 obj-y += stdio.o
 
-CPPFLAGS += -I..
-
 $(obj)env_embedded.o: $(src)env_embedded.c
 	$(CC) $(AFLAGS) -Wa,--no-warn \
 		-DENV_CRC=$(shell $(obj)../tools/envcrc) \
-- 
1.8.3.2



More information about the U-Boot mailing list