[U-Boot] examples: add again x86 standalone example

Simon Glass sjg at chromium.org
Fri Nov 29 00:32:24 CET 2013


Hi,

On 27 November 2013 21:07, Graeme Russ <graeme.russ at gmail.com> wrote:

> Hi Guys,
>
>
> On Thu, Nov 28, 2013 at 2:44 PM, Masahiro Yamada <
> yamada.m at jp.panasonic.com> wrote:
>
>> Hello Tom, Simon.
>>
>>
>>
>> > On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote:
>> >
>> > > Commit fea25720 renamed arch/i386 to arch/x86.
>> > > But it missed to modify examples/standalone/Makefile.
>>
>
> Oops - my bad :)
>
>
>>  > >
>> > > This commit revives examples/standalone/82559_eeprom.
>> > >
>> > > Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>> > > Cc: Simon Glass <sjg at chromium.org>
>> > >
>> > > ---
>> > > Hello, Simon.
>> > >
>> > > I think examples/standalone/82559_eeprom should have been
>> > > originally implemented for i386(x86) architecture
>> > > but it has never compiled more than two years.
>> > > (And I am probably the first one to notice this.)
>> > >
>> > > I chosed to add it again rather than delete it in this patch.
>> > > If you do not need it any more, I am glad to re-post v2
>> > > to delete it.
>> >
>> > Note that now that we build this I see:
>> > i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom;
>> > defaulting to 0000000000040000
>> >
>> > So a new warning on coreboot-x86.  I'm giving this patch to Simon in
>> > patchwork and he can either follow-up with a patch fixing the warning or
>> > nak and delete the example.
>>  <http://lists.denx.de/mailman/listinfo/u-boot>
>>
>
> To be honest, I don't think this will ever be used. 'Hello World' provides
> a perfect example of a standalone application on the x86 as it stands
> already.
>
> The 82559 is the EEPROM for the Intel Fast Ethernet controller, and as
> such, I think any interface to it should be done via a proper driver and
> not by a standalone application. Besides, I really doubt that there are any
> systems using an 82559 and U-Boot in the wild, and probably never will be.
>
> I vote for deletion
>

Thanks Graeme. Fine with me. Masahiro will do you a patch or should I?

Regards,
Simon


More information about the U-Boot mailing list