[U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

Pantelis Antoniou panto at antoniou-consulting.com
Fri Nov 29 13:02:45 CET 2013


Hi Alexey,

On Nov 29, 2013, at 12:08 PM, Alexey Brodkin wrote:

> On Fri, 2013-11-29 at 19:00 +0900, Jaehoon Chung wrote:
>> remove this and use callback function like the host->board_init()?
>> if (host->board_init())
>> 	host->board_init(host);
>> 
>> Then we can reuse the this function for board specific code.
>> Anyway, I think that exynos code didn't exist at here(dw-mmc.c).
>> 
>> Best Regards,
>> Jaehoon Chung
>>> 
>>> 	dwmci_writel(host, DWMCI_PWREN, 1);
>>> 
>>> 
>> 
> 
> I may do this change but I don't own corresponding HW (Exynos-5420
> based) so I won't be able to test my changes.
> 
> And that's why I propose to apply this patch so driver is now again gets
> built for any platform and if anybody who have access to Exynos-5420 HW
> have some time to clean-up then it's good, anyways people will be happy
> again :)
> 
> -Alexey
> 
> P.S. I saw you reply on v1 patch you just sent - so feel free to
> clean-up the driver if it's ok for you or let's keep my "work-around"
> for now.

All looks good from my side;

Please do a boot test on the real hardware and let me know before
I can apply.

Regards

-- Pantelis



More information about the U-Boot mailing list