[U-Boot] [PATCH] usb: Fix error handling in musb_hcd.c

Marek Vasut marex at denx.de
Thu Oct 3 17:56:09 CEST 2013


Dear Andrew Murray,

> The wait_until_[rx|tx]ep_ready functions return a u8 to indicate success
> containing the value 0, 1 or -1. This patch changes the return type to an
> int to accommodate the negative return values.
> 
> These functions are used in the file using calls such as if (!wait_until...
> Where a -1 is returned it is mishandled and treated as success instead of
> a CRC error. This patch addresses this.
> 
> Cc: Marek Vasut <marex at denx.de>
> Cc: Tom Rini <trini at ti.com>
> Signed-off-by: Andrew Murray <amurray at embedded-bits.co.uk>

Acked-by: Marek Vasut <marex at denx.de>

Tom, feel free to pick this up if it's ok on this omap hardware.

Best regards,
Marek Vasut


More information about the U-Boot mailing list