[U-Boot] [PATCH] Fix number base handling of "load" command

Tom Rini trini at ti.com
Mon Oct 7 22:04:18 CEST 2013


On Sat, Oct 05, 2013 at 09:07:25PM +0200, Wolfgang Denk wrote:

> A documented, almost all U-Boot commands expect numbers to be entered
> in hexadecimal input format. (Exception: for historical reasons, the
> "sleep" command takes its argument in decimal input format.)
> 
> This rule was broken for the "load" command; for details please see
> especially commits 045fa1e "fs: add filesystem switch libary,
> implement ls and fsload commands" and 3f83c87 "fs: fix number base
> behaviour change in fatload/ext*load".  In the result, the load
> command would always require an explicit "0x" prefix for regular
> (i. e. base 16 formatted) input.
> 
> Change this to use the standard notation of base 16 input format.
> While strictly speaking this is a change of the user interface, we
> hope that it will not cause trouble.  Stephen Warren comments (see
> [1]):
> 
>         I suppose you can change the behaviour if you want; anyone
>         writing "0x..." for their values presumably won't be
>         affected, and if people really do assume all values in U-Boot
>         are in hex, presumably nobody currently relies upon using
>         non-prefixed values with the generic load command, since it
>         doesn't work like that right now.
> 
> [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/171172
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> cc: Tom Rini <trini at ti.com>, u-boot at lists.denx.de
> cc: Stephen Warren <swarren at nvidia.com>

Manually correcting the commit message typo, applied to u-boot/master,
thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131007/753d7825/attachment.pgp>


More information about the U-Boot mailing list