[U-Boot] [PATCH] env_mmc: fix buffer allocation for armv7

Wolfgang Denk wd at denx.de
Tue Oct 8 20:17:01 CEST 2013


Dear Tom,

In message <20131008134456.GB15917 at bill-the-cat> you wrote:
> 
> > Well, if we have DDR such that we can use it for the malloc arena, we
> > also should use it for the stack.  Or is there a good reason for not
> > doing this?  It would solve all these issues at the root...
> 
> Making SPL more complex for everyone?  We would need to do a fairly
> good-sized re-jigger of SPL to setup and swap around stack pointers like
> we do in full U-Boot.

Hm,  I'm not convinced.  As proposed, we make the code bigger, less
efficient, more error prone and more ugly for everyone, not only for
SPL users.  Aslo, this might not be the only place where buffers or
such may be kept on the stack.  I hope you don't want to change all
these?

Really, if we have the resources, we should use them.  If RAM is
abailable, it should also be used for the stack.  Just using it for
malloc() is neither fish nor fowl.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Have you lived in this village all your life?"        "No, not yet."


More information about the U-Boot mailing list