[U-Boot] [PATCH 3/8] Tegra124: Add SPL/AVP (arm720t) cpu files

Stephen Warren swarren at wwwdotorg.org
Tue Oct 8 23:34:33 CEST 2013


On 10/08/2013 02:13 AM, Thierry Reding wrote:
> On Tue, Oct 08, 2013 at 12:42:53AM +0200, Tom Warren wrote:
>> This provides SPL support for T124 boards - AVP early init, plus
>> CPU (A15) init/jump to main U-Boot.

>> soc_type = tegra_get_chip(); -               if (soc_type ==
>> CHIPID_TEGRA30 || soc_type == CHIPID_TEGRA114) +               if
>> (soc_type == CHIPID_TEGRA30 || soc_type == CHIPID_TEGRA114 || +
>> soc_type == CHIPID_TEGRA124)
> 
> Perhaps:
> 
> if (soc_type >= CHIPID_TEGRA30)

Given that the only exception is Tegra20, wouldn't it be better as:

if (soc_type == CHIPID_TEGRA20)

and then swap the Tegra20/not-Tegra20 branches of the if statement?


More information about the U-Boot mailing list