[U-Boot] [PATCH 2/4] Coding Style cleanup: replace leading SPACEs by TABs

Simon Glass sjg at chromium.org
Wed Oct 9 17:33:53 CEST 2013


Hi Tom,

On Wed, Oct 9, 2013 at 9:29 AM, Tom Rini <trini at ti.com> wrote:

> On Wed, Oct 09, 2013 at 08:02:10PM +0900, Masahiro Yamada wrote:
> > Hello, Wolfgang, Simon.
> >
> > (I added Cc Simon)
> >
> >
> > >  tools/buildman/README                              |  268 +--
> > >  tools/buildman/board.py                            |  236 +-
> > >  tools/buildman/bsettings.py                        |   18 +-
> > >  tools/buildman/builder.py                          | 2374
> ++++++++++----------
> > >  tools/buildman/buildman.py                         |   16 +-
> > >  tools/buildman/control.py                          |  136 +-
> > >  tools/buildman/test.py                             |  162 +-
> > >  tools/buildman/toolchain.py                        |  392 ++--
> >
> > I might be too worried, but so many lines are going to be changed.
> > Just in case, I hope Simon checks this.
>
> I'm not sure whacking the whitespace in quasi-external (I know patman is
> used outside U-Boot, I forget about buildman) python tools is the right
> way to go here.  Today the tools are consistent and space-only.  This
> makes it mix-and-match.
>

patman also. The coding style I tried to follow for Python is PEP 8 - with
spaces. At least it is consistent.

Regards,
Simon


More information about the U-Boot mailing list