[U-Boot] [PATCH 1/3] spi: omap3: add support for more word lengths

[Gerhard Sittig]

On Wed, Oct 09, 2013 at 17:46 +0300, Nikita Kiryanov wrote:
> 
> --- a/drivers/spi/omap3_spi.c
> +++ b/drivers/spi/omap3_spi.c
> @@ -20,7 +20,7 @@
>  #include <asm/io.h>
>  #include "omap3_spi.h"
>  
> -#define WORD_LEN	8
> +#define SPI_DEFAULT_WORDLEN 8;
>  #define SPI_WAIT_TIMEOUT 3000000;
>  
>  static void spi_reset(struct omap3_spi_slave *ds)

This is strictly speaking unrelated to your change, but might be
worth getting fixed in a separate submission.  I haven't read
your patch in the meaning of a review, just happened to spot this
nit before skipping to the next message ...

The semicolon in a #define for a constant is certainly wrong.
This applies to both your new line as well as the context which
already was in place.  The code may appear to work, but for
sanity and to avoid future problems the defines should get fixed.
You might add the separate cleanup patch in front of the new
feature should feedback make you send another version of your
series, or send a fix individually (and check for other
occurances for bonus points).


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de