[U-Boot] [PATCH 1/2] buildman: don't fail --list-toolchains when toolchains fail

Simon Glass sjg at chromium.org
Thu Oct 10 17:50:31 CEST 2013


Hi Stephen,

On Thu, Oct 10, 2013 at 9:48 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 10/09/2013 04:24 PM, Simon Glass wrote:
>> On Wed, Oct 9, 2013 at 2:28 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>> From: Stephen Warren <swarren at nvidia.com>
>>>
>>> When a toolchain invocation fails, an exception is thrown but not caught
>>> which then aborts the entire toolchain detection process. To solve this,
>>> request that exceptions not be thrown, since the toolchain init code
>>> already error-checks the command result. This solves e.g.:
>>>
>>>          - found '/usr/bin/winegcc'
>>> Traceback (most recent call last):
>>> ...
>>> Exception: Error running '/usr/bin/winegcc --version'
>>>
>>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>>
>> Acked-by: Simon Glass <sjg at chromium.org>
>
> Thanks. Oh. I didn't send this patch directly to any person other than
> you, since I thought you collected patches and sent pull requests for
> it. Should I resend it to Tom Rini?

Yes I tend to do that. Perhaps this should go into the release? Let me
know - I'll do a little pull request for Tom.

Regards,
Simon


More information about the U-Boot mailing list