[U-Boot] [PATCH 2/3] lcd: add DataImage SCF0403x LCD panel support

Anatolij Gustschin agust at denx.de
Thu Oct 10 18:57:08 CEST 2013


On Wed,  9 Oct 2013 17:46:04 +0300
Nikita Kiryanov <nikita at compulab.co.il> wrote:
...
> diff --git a/drivers/video/scf0403_lcd.c b/drivers/video/scf0403_lcd.c
> new file mode 100644
> index 0000000..1d1c3ff
> --- /dev/null
> +++ b/drivers/video/scf0403_lcd.c
> @@ -0,0 +1,298 @@
> +/*
> + * scf0403.c -- support for DataImage SCF0403 LCD
> + *
> + * Copyright (c) 2013 Adapted from Linux driver:
> + * Copyright (c) 2012 Anders Electronics plc. All Rights Reserved.
> + * Copyright (c) 2012 CompuLab, Ltd
> + *           Dmitry Lifshitz <lifshitz at compulab.co.il>
> + *           Ilya Ledvich <ilya at compulab.co.il>
> + * Inspired by Alberto Panizzo <maramaopercheseimorto at gmail.com> &
> + *	Marek Vasut work in l4f00242t03.c
> + *
> + * U-Boot port: Nikita Kiryanov <nikita at compulab.co.il>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

please use "SPDX-License-Identifier:	GPL-2.0" here.
See Licenses/README for more info.

...
> +	for (i = 0; i < priv->seq_size; i++) {
> +		if (scf0403_spi_transfer(priv->spi, &priv->init_seq[i].cmd) < 0)
> +			printf("SPI transfer failed\n");

using puts() for not formatted strings is preferred, please
check in other places, too.


> +++ b/include/scf0403_lcd.h
> @@ -0,0 +1,22 @@
...
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc.

also please use SPDX license identifier here, too.

Thanks,

Anatolij



More information about the U-Boot mailing list