[U-Boot] [PATCH v8 1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform
Scott Wood
scottwood at freescale.com
Fri Oct 11 19:42:59 CEST 2013
On Fri, 2013-10-11 at 05:27 +0000, Gupta, Pekon wrote:
> > From: Scott Wood [mailto:scottwood at freescale.com]
> > On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote:
> [snip]
> > > -#else
> > > + } else {
> > > /*
> > > * This ecc_size_config setting is for BCH sw library.
> > > *
> > > @@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip
> > *chip, int32_t mode)
> > > * size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area)
> > > */
> > > val = (32 << 22) | (0 << 12);
> > > -#endif
> > > + }
> >
> > Either indentation or braces are wrong above. If it's just the
> > indentation that's wrong, let me know and I can fix up when applying.
> >
> Yes, thanks. I did run checkpatch.pl but may be because code here is
> not part of the changed lines, so it did not give the indentation warning.
It seems that checkpatch.pl only checks the indentation of the first
line of the if-body, and not the subsequent lines or anything in the
else-body.
> Do we have any checkpatch utility for u-boot ?
tools/checkpatch.pl
-Scott
More information about the U-Boot
mailing list