[U-Boot] [Patch v1 1/1] jffs2: change U_BOOT_CMD ls to fsls

[Wolfgang Denk]

Dear Suriyan Ramasami,

In message <1381366918-17590-1-git-send-email-suriyan.r at gmail.com> you wrote:
> multiple definitions of `_u_boot_list_2_cmd_2_ls' if CONFIG_CMD_JFFS2
> and CONFIG_CMD_FS_GENERIC are defined.
> 
> Signed-off-by: Suriyan Ramasami <suriyan.r at gmail.com>
> ---
>  common/cmd_jffs2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
> index bce0983..f38455f 100644
> --- a/common/cmd_jffs2.c
> +++ b/common/cmd_jffs2.c
> @@ -606,7 +606,7 @@ U_BOOT_CMD(
>  	"      with offset 'off'"
>  );
>  U_BOOT_CMD(
> -	ls,	2,	1,	do_jffs2_ls,
> +	fsls,	2,	1,	do_jffs2_ls,

This makes no sense to me.  Either we mimick Unix style, then the
command name shouldbe "ls' (where else but in a file system could you
LiSt files?); or we implement file system specific commands, than the
name of the file system should be recognizable.

I think your problem should be fixed differently (such that "ls" also
works with JFFS2).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
backups: always in season, never out of style.