[U-Boot] [PATCH 0/3] All M68K boards are broken

[Masahiro Yamada]

Hello.

Even after applying the patch
"config.mk: fix -fstack-usage support test"
(http://patchwork.ozlabs.org/patch/283619/),
I still cannot compile m68k correctly.


The result of `CROSS_COMPILE=m68k-linux- ./MAKEALL -a m68k` is 

    --------------------- SUMMARY ----------------------------
    Boards compiled: 50
    Boards with errors: 6 ( M5253DEMO M54455EVB M54455EVB_a66
    M54455EVB_i66 M54455EVB_intel M54455EVB_stm33 )
    Boards with warnings but no errors: 44 ( M52277EVB
    M52277EVB_stmicro M5235EVB M5235EVB_Flash32 idmr cobra5272
    eb_cpu5282 eb_cpu5282_internal TASREG M5208EVBE M5249EVB
    M5253EVBE M5271EVB M5272C3 M5275EVB M5282EVB astro_mcf5373l
    M53017EVB M5329AFEE M5329BFEE M5373EVB M54418TWR
    M54418TWR_nand_mii M54418TWR_nand_rmii M54418TWR_nand_rmii_lowfreq
    M54418TWR_serial_mii M54418TWR_serial_rmii M54451EVB M54451EVB_stmicro
    M5475AFE M5475BFE M5475CFE M5475DFE M5475EFE M5475FFE M5475GFE
    M5485AFE M5485BFE M5485CFE M5485DFE M5485EFE M5485FFE M5485GFE M5485HFE )
    ----------------------------------------------------------


I just took a look and 
I found lots of files are left broken for a long term.


I pick up some them here.


(1) drivers/i2c/i2c_core.c
i2c_core.c: In function 'i2c_reloc_fixup':
i2c_core.c:63:20: warning: assignment from incompatible pointer type [enabled by default]
i2c_core.c:67:21: warning: assignment from incompatible pointer type [enabled by default]
i2c_core.c:71:20: warning: assignment from incompatible pointer type [enabled by default]
i2c_core.c:76:21: warning: assignment from incompatible pointer type [enabled by default]
i2c_core.c:81:29: warning: assignment from incompatible pointer type [enabled by default]

(2) arch/m68k/lib/bootm.c

bootm.c:53:8: warning: unused variable 'rd_len' [-Wunused-variable]
bootm.c:99:12: warning: 'initrd_start' may be used uninitialized in this function [-Wuninitialized]
bootm.c:99:12: warning: 'initrd_end' may be used uninitialized in this function [-Wuninitialized]
bootm.c:99:12: warning: 'cmd_start' may be used uninitialized in this function [-Wuninitialized]
bootm.c:99:12: warning: 'cmd_end' may be used uninitialized in this function [-Wuninitialized]

(3) arch/m68k/cpu/mcf5445x/cpu_init.c

cpu_init.c:367:21: warning: unused variable 'info' [-Wunused-variable]

(4)
cpu_init.c:48:2: warning: passing argument 1 of 'out_be32' from incompatible pointer type [enabled by default]
arch/m68k/include/asm/io.h:207:20: note: expected 'volatile unsigned int *' but argument is of type 'u16 *'
cpu_init.c:49:2: warning: passing argument 1 of 'out_be32' from incompatible pointer type [enabled by default]
arch/m68k/include/asm/io.h:207:20: note: expected 'volatile unsigned int *' but argument is of type 'u16 *'

(5)
include/configs/M5253DEMO.h:1:1: error: unknown type name 'TABILITY'
include/configs/M5253DEMO.h:1:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'FITNESS'
include/configs/M5253DEMO.h:1:13: error: unknown type name 'FITNESS'
include/configs/M5253DEMO.h:2:2: error: stray '@' in program

(6)
cpu_init.c: In function 'cpu_init_f':
cpu_init.c:211:10: warning: unused variable 'wdog' [-Wunused-variable]

(7)
mcf5373l.c: In function 'initdram':
mcf5373l.c:83:5: warning: pointer targets in passing argument 1 of 'get_ram_size' differ in signedness [-Wpointer-sign]
include/common.h:456:6: note: expected 'long int *' but argument is of type 'long unsigned int *'

(8)
fpga.c:168:2: warning: initialization from incompatible pointer type [enabled by default]
fpga.c:168:2: warning: (near initialization for 'altera_fns.write') [enabled by default]
fpga.c: In function 'astro5373l_altera_load':
fpga.c:196:20: warning: assignment from incompatible pointer type [enabled by default]


(9)
speed.c: In function 'setup_5441x_clocks':
speed.c:118:2: warning: passing argument 1 of 'in_be16' makes pointer from integer without a cast [enabled by default]
arch/m68k/include/asm/io.h:177:19: note: expected 'volatile u16 *' but argument is of type 'u16'

(10)
fsl_i2c.c:50:39: error: 'CONFIG_SYS_FSL_I2C_OFFSET' undeclared here (not in a function)



I began to fix some of them and I gave up on the way.

Who is the custodian of M68K?
I doubt M68K is maintained.


Masahiro Yamada (3):
  i2c: eliminate warnings in i2c_reloc_fixup function
  m68k: eliminate warnings in do_bootm_linux function
  m68k: eliminate a warning in cpu_init

 arch/m68k/cpu/mcf5445x/cpu_init.c |  2 +-
 arch/m68k/lib/bootm.c             |  7 ++++++-
 drivers/i2c/i2c_core.c            | 12 +++++-------
 3 files changed, 12 insertions(+), 9 deletions(-)

-- 
1.8.1.2