[U-Boot] [PATCH 1/6] exynos_fb: Remove usage of static defines

Simon Glass sjg at chromium.org
Wed Oct 16 18:34:47 CEST 2013


Hi Ajay,

[once more from the right address]

On Mon, Sep 30, 2013 at 5:20 AM, Ajay Kumar <ajaykumar.rs at samsung.com>wrote:

> Previously, we used to statically assign values for vl_col, vl_row and
> vl_bpix using #defines like LCD_XRES, LCD_YRES and LCD_COLOR16.
>
> Introducing the function exynos_lcd_early_init() would take care of this
> assignment on the fly by parsing FIMD DT properties, thereby allowing us
> to remove LCD_XRES and LCD_YRES from the main config file.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
>

Acked-by: Simon Glass <sjg at chromium.org>

I can't test this on Pit at present - any chance of a series at some point
to enable that?

I pushed my branch to u-boot-x86.git branch try-5420b.

As a general comment, it would be nice to follow up with a series to fully
enable device tree for the GPIOs also. At the moment these are hard-coded.

Regards,
Simon


More information about the U-Boot mailing list