[U-Boot] [U-Boot, 1/3, v4] exynos: i2c: Fix i2c driver to handle NACKs properly

Heiko Schocher hs at denx.de
Thu Oct 17 08:29:47 CEST 2013


Hello Naveen,

Am 15.10.2013 12:31, schrieb Naveen Krishna Ch:
> The Exynos5 i2c driver does not handle NACKs properly. This change:
>
> - fixes the NACK processing problem (do not continue transaction if
>    address cycle was NACKed)
>
> - eliminates a fair amount of duplicate code
>
> Signed-off-by: Vadim Bendebury<vbendeb at chromium.org>
> Reviewed-by: Simon Glass<sjg at google.com>
> Signed-off-by: Naveen Krishna Chatradhi<ch.naveen at samsung.com>
>
> ---
> Changes since v1:
> Fixed complilation warning in function i2c_init()
>
> Changes since v2:
> None
>
> Changes since v3:
> None; ran # ./MAKEALL -v samsung
>
>   drivers/i2c/s3c24x0_i2c.c |  214 +++++++++++++++++++--------------------------
>   1 file changed, 90 insertions(+), 124 deletions(-)

Applied to u-boot-i2c.git

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list