[U-Boot] [PATCH v4 3/6] fs: move some file system to fs/Makefile

Simon Glass sjg at chromium.org
Fri Oct 18 23:29:37 CEST 2013


On Thu, Oct 17, 2013 at 6:58 PM, Masahiro Yamada
<yamada.m at jp.panasonic.com>wrote:

> Hello Simon.
>
>
> > > diff --git a/Makefile b/Makefile
> > > index 75e93c4..ba521e1 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -248,17 +248,7 @@ endif
> > >  LIBS-$(CONFIG_OF_EMBED) += dts/libdts.o
> > >  LIBS-y += arch/$(ARCH)/lib/lib$(ARCH).o
> > >  LIBS-y += fs/libfs.o \
> > > -       fs/cbfs/libcbfs.o \
> > > -       fs/cramfs/libcramfs.o \
> > > -       fs/ext4/libext4fs.o \
> > > -       fs/fat/libfat.o \
> > > -       fs/fdos/libfdos.o \
> > > -       fs/jffs2/libjffs2.o \
> > > -       fs/reiserfs/libreiserfs.o \
> > > -       fs/sandbox/libsandboxfs.o \
> > > -       fs/ubifs/libubifs.o \
> > > -       fs/yaffs2/libyaffs2.o \
> > > -       fs/zfs/libzfs.o
> > > +       fs/fat/libfat.o
> >
> > Why do you keep libfat here?
>
>
>
> Please see around line 88 of spl/Makefile
>
>   LIBS-$(CONFIG_SPL_FAT_SUPPORT) += fs/fat/libfat.o
>
>
> fs/fat/ is invoked also from spl/Makefile.
>
>
> In order to move libfat, we need treak more.
> Of course we can do this refactoring,
> but it might be a little beyond the series
> and I was afraid reviewers might be confused.
>
> That's why I decided to postpone to move libfat.
>

OK.

Acked-by: Simon Glass <sjg at chromium.org>


>
>
>
> OK. I will post the follow-up patch
> to move libfat.
>
>
>
>
> Best Regards
> Masahiro Yamada
>
>


More information about the U-Boot mailing list