[U-Boot] [PATCH] kirkwood: ib62x0: use device tree and update config

[Marek Vasut]

Dear Luka Perkov,

> Hi Fabio,
> 
> On Sun, Oct 13, 2013 at 11:41:44PM -0300, Fabio Estevam wrote:
> > On Sun, Oct 13, 2013 at 11:38 PM, Luka Perkov <luka at openwrt.org> wrote:
> > >  /*
> > > 
> > > - * Machine type
> > > + * Enable device tree support
> > > 
> > >   */
> > > 
> > > -#define CONFIG_MACH_TYPE       MACH_TYPE_NAS6210
> > > +#define CONFIG_OF_LIBFDT
> > 
> > I am not familiar with this platform, but couldn't you also keep
> > CONFIG_MACH_TYPE ?
> > 
> > This way people have the option to load both dt and non-dt kernels.
> 
> Upstream uses only DT. When uboot support was pushed we had non-DT
> kernel patches that were never merged upstream. IMO we should just drop
> CONFIG_MACH_TYPE and use CONFIG_OF_LIBFDT.

You are breaking compatibility here, so you should keep the machine ID .

Best regards,
Marek Vasut