[U-Boot] [RFC PATCH 1/2] usb: dfu: decrease dfu->r_left along with the transfer

Lukasz Majewski l.majewski at majess.pl
Tue Oct 22 00:24:50 CEST 2013


Hi Marek,

> Hi,
> 
> > The value of dfu->r_left need decrease along with the transfer
> > 
> > Signed-off-by: Bo Shen <voice.shen at atmel.com>
> 
> Lucasz/Heiko , can you ACK/NAK this and 2/2 ? Thanks!

For me it looks like a more difficult problem. 
I've got an impression that patches proposed by Bo would break eMMC.

Unfortunately I'm now a bit short of time to go deeper to it. Before
ELCE I shall have got a bit more time.

> 
> > ---
> >  drivers/dfu/dfu.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> > index 56b21c7..65c6984 100644
> > --- a/drivers/dfu/dfu.c
> > +++ b/drivers/dfu/dfu.c
> > @@ -229,6 +229,7 @@ static int dfu_read_buffer_fill(struct
> > dfu_entity *dfu, void *buf, int size) dfu->crc = crc32(dfu->crc,
> > buf, chunk); dfu->i_buf += chunk;
> >  			dfu->b_left -= chunk;
> > +			dfu->r_left -= chunk;
> >  			size -= chunk;
> >  			buf += chunk;
> >  			readn += chunk;
> 
> Best regards,
> Marek Vasut

Regards,
Lukasz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131022/7623890f/attachment.pgp>


More information about the U-Boot mailing list