[U-Boot] [RESEND PATCH 2/3] mx28evk: Add 'nandboot' environment command

[Otavio Salvador]

On Mon, Oct 28, 2013 at 9:32 AM, Stefano Babic <sbabic at denx.de> wrote:
> Hi Otavio,
>
> On 28/10/2013 12:19, Otavio Salvador wrote:
>> Hello,
>>
>> I am not sure I agree ...
>>
>> On Sun, Oct 27, 2013 at 6:47 PM, Marek Vasut <marex at denx.de> wrote:
>>> Dear Otavio Salvador,
>>>
>>>> On Sun, Oct 27, 2013 at 2:16 PM, Marek Vasut <marex at denx.de> wrote:
>>>>> Dear Otavio Salvador,
>>>>>
>>>>>> This reads the kernel, ftd and boot into ubifs filesystem. While on
>>>>>> that, the SD firmware filename definition has been moved next to the
>>>>>> other SD related commands.
>>>>>>
>>>>>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>>>>>
>>>>> Any changes to built-in environment are now NAKd I believe.
>>>>
>>>> I don't see a reason to not merged it for now; I will work in porting
>>>> the environments for the external file but this could go now, anyway.
>>>
>>> Read [1], in particular what Stefano said.
>>>
>>> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/169042
>>>
>>> Thus this patch shall be rejected as well, sorry.
>>
>> I agree with the goal but until we have a way to insert the /default/
>> environment into the binary of U-Boot for use (not adding an extra
>> environment image) this should be accepted.
>
> Indeed. However, why cannot we do the right thing soon ?

There're no pending patches to address the root problem yet (allowing
changing /internal and default/ environment).

> It is very interesting if Simon's patches will flow into mainline soon -
> as feeling, I see some comments by Wolfgang, but no evident signal that
> they will be stopped. Octavio, I will wait for your patches for a while
> and if Simon's patches will be accepted soon, I will kindly ask you to
> reformat your patches, moving the default environment into an .env file.

I will rework the environments as .env files but I don't want to hold
this change until this is accepted.

My patch is fine and could go in now as is. Once Simon's patches get
in I will post another series reworking the environment to convert it
to the .env file format but please don't block on this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750