[U-Boot] [RFC PATCH 1/3] USB: gadget: add atmel usba udc driver

Marek Vasut marex at denx.de
Wed Sep 4 03:55:06 CEST 2013


Dear Bo Shen,

> Hi Marek Vasut,
> 
> On 09/04/2013 06:30 AM, Marek Vasut wrote:
> > Dear Bo Shen,
> > 
> >> Add atmel usba udc driver support, porting from Linux kernel
> >> 
> >> Signed-off-by: Bo Shen <voice.shen at atmel.com>
> > 
> > Please see [1] , point 4. I miss the exact point in Linux kernel history
> > (read commit hash) from which this code was imported at least.
> > 
> > [1]
> > http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_
> > Sign
> 
> Thanks.
> 
> I will add this information into v2 after you finish reviewing the code.
> 
> The original code information from Linux kernel as following
> ---8>---
> commit e01ee9f509a927158f670408b41127d4166db1c7
> Author: Jingoo Han <jg1.han at samsung.com>
> Date:   Tue Jul 30 17:00:51 2013 +0900
> 
>      usb: gadget: use dev_get_platdata()
> 
>      Use the wrapper function for retrieving the platform data instead of
>      accessing dev->platform_data directly.
> 
>      Signed-off-by: Jingoo Han <jg1.han at samsung.com>
>      Signed-off-by: Felipe Balbi <balbi at ti.com>
> ---<8---
> 

The code looks pretty much OK.

Best regards,
Marek Vasut


More information about the U-Boot mailing list