[U-Boot] [RFC PATCH 3/3] ARM: atmel: add RNDIS gadget support

Andreas Bießmann andreas.devel at googlemail.com
Wed Sep 4 09:32:54 CEST 2013


Hi Bo, Marek,

On 09/04/2013 04:01 AM, Bo Shen wrote:
> Hi Marek Vasut,
> 
> On 09/04/2013 09:55 AM, Marek Vasut wrote:
>>> >I have considered to put this in driver, however, different Atmel SoC
>>> >have different attributes for each endpoint and different number of
>>> >endpoint.
>>> >
>>> >for example;
>>> >at91sam9x5: EP("ep1", 1, 1024, 2, 1, 1)
>>> >sama5d3x: EP("ep1", 1, 1024, 3, 1, 0)
>>> >
>>> >So, if I put this in driver, there will be many #ifdef. If newly SoC
>>> >added, maybe we will need to add #ifdef again. So, I put it here.
>> Can you not pull it into some header file at least? Having it in the
>> board file
>> will clearly result in duplication.
> 
> OK, I will put it into header file.

I'm fine with a header too. But for the records, the mentioned file is
_not_ board code but SoC code.

Best regards

Andreas Bießmann


More information about the U-Boot mailing list