[U-Boot] [PATCH] config: consolidate CONFIG_SYS_HZ definition

Wolfgang Denk wd at denx.de
Mon Sep 9 16:06:29 CEST 2013


Dear Rob Herring,

In message <1378670088-17602-1-git-send-email-robherring2 at gmail.com> you wrote:
>
...
> diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
> index e59ee96..4c25289 100644
> --- a/include/config_fallbacks.h
> +++ b/include/config_fallbacks.h
> @@ -53,4 +53,8 @@
>  #define HAVE_BLOCK_DEVICE
>  #endif
>  
> +#ifndef CONFIG_SYS_HZ
> +#define CONFIG_SYS_HZ		1000
> +#endif

This should be not a fallback (i. e. default value) which can be
silently overwritten - this should be a mandatory definition that
causes build errors if somebody tries to define a different value.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Steal five dollars and you were a petty  thief.  Steal  thousands  of
dollars and you are either a government or a hero.
                                   - Terry Pratchett, _Going_Postal_


More information about the U-Boot mailing list